feat: add option to draw rectangle with start and end points #7489
+237
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7489 +/- ##
=======================================
Coverage 99.50% 99.50%
=======================================
Files 271 271
Lines 11027 11076 +49
Branches 2656 2666 +10
=======================================
+ Hits 10972 11021 +49
Misses 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
santicomp2014
left a comment
santicomp2014
left a comment
There was a problem hiding this comment.
LGTM, we need to update the test to pass the test
| this._surface.addEventListener('pointerup', e => { | ||
| // If we're waiting for second click, don't process pointerup | ||
| // (the second click will be handled in pointerdown) | ||
| if (this._waitingForSecondClick) { |
Contributor
There was a problem hiding this comment.
We need to also add a unit test to cover this branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for creating rectangle annotations using two clicks to define the start and end points. Existing functionality remains unchanged.