Skip to content

fix: flat portal topics without separator #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexluong merged 4 commits into from
Jan 20, 2026
Merged

fix: flat portal topics without separator #651

alexluong merged 4 commits into from
Jan 20, 2026
+58 −33

Conversation

@alexluong
Copy link
Collaborator

@alexluong alexluong commented Jan 19, 2026 •
edited
Loading

CleanShot 2026-01-20 at 04 35 11

@vercel
Copy link

vercel bot commented Jan 19, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
outpost-docs Ready Ready Preview, Comment Jan 19, 2026 10:07pm
outpost-website Ready Ready Preview, Comment Jan 19, 2026 10:07pm

Request Review

alexluong and others added 2 commits January 20, 2026 04:48
@alexluong @claude
refactor: remove redundant tenant_id from portal redirect URL
20463b2 
The tenant_id is already embedded in the JWT token's sub claim,
so it's unnecessary in the URL query parameter.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@alexluong @claude
fix(portal): handle mixed flat and nested topics in TopicPicker
6320605 
Topics are now parsed individually for separators instead of
requiring all topics to share the same separator. This allows
flat topics (job, document) to render without nesting while
hierarchical topics (user.created, user.updated) are grouped.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@alexluong @claude
test: update tests for tenant topics and portal URL changes
bdbc535 
- Update e2e test to expect literal ["*"] for tenant topics with
  wildcard destination (matches 78f162e behavior change)
- Update portal handler tests to check for token= instead of
  tenant_id= in redirect URL (matches 20463b2 refactor)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@alexluong alexluong merged commit dcf9525 into main Jan 20, 2026
4 checks passed
@alexluong alexluong deleted the portal-topics branch January 20, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexbouchardd alexbouchardd alexbouchardd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexluong @alexbouchardd