fix: tenant pagination #648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexbouchardd
approved these changes
Jan 19, 2026
Adds paginationtest.Suite for ListTenant to verify proper cursor-based pagination behavior. These tests currently fail because the existing implementation doesn't use the n+1 pattern to detect hasMore. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use pagination.Run for proper hasMore detection via n+1 pattern. Last page now has no Next cursor, first page has no Prev cursor. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add TestListTenantPagination_WithDeploymentID variant - Rename RedisStack tests to _Compat_ suffix - Dragonfly is now the primary test target Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove TestListTenantPagination (covered by paginationtest.Suite) - Remove outdated offset-based delete edge case test - Rename TestListTenantBasic → TestListTenantEnrichment - Rename TestListTenantPaginationEdgeCases → TestListTenantKeysetPagination - Remove redundant ordering subtests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
alexluong
force-pushed
the
tenant-pagination
branch
from
6edd466 to
774fd48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses pagination pkgs in #647 to implement List Tenant API. Supports detecting end of pagination and avoid returning cursor that leads to nowhere.