Merged
Conversation
Replace external dependencies with local implementations: - parse-procfile: Implemented Procfile parsing directly in load-foreman-procfile.ts with proper TypeScript types - github-url-to-object: Implemented parseGitHubUrl function in git.ts to handle SSH and HTTPS GitHub URL formats Also updated package dependency ranges to use caret (^) for better semver flexibility and moved test-only dependencies (mock-stdin, stdout-stderr) to devDependencies. The local implementations maintain identical behavior while reducing external dependencies and improving type safety.
eablack
changed the title
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes two small external dependencies that haven't been updated in many years and replaces them with local implementations:
load-foreman-procfile.tswith proper TypeScript typesparseGitHubUrlfunction ingit.tsto handle SSH and HTTPS GitHub URL formatsAlso updated package dependency ranges to use caret (^) for better semver flexibility and moved test-only dependencies (
mock-stdin,stdout-stderr) to devDependencies.semverwas also completely removed as a direct dependency because it appears to be unused.heroku-cli-utilis also updated to 10.5.0, introducing the HEROKU_THEME feature.removed a monorepo smoke test that is no longer relevant (enabling us to remove globby as a dependency)
Type of Change
Testing
Notes:
All existing tests pass. The local implementations maintain identical behavior to the original packages.
Related Issues
Part of package.json cleanup for v11.0.0