Skip to content

Working on allowing prerelease schemas to partner with prerelease standard#1241

Merged
VisLab merged 4 commits intohed-standard:mainfrom
VisLab:fix_extras
Feb 26, 2026
Merged

Working on allowing prerelease schemas to partner with prerelease standard#1241
VisLab merged 4 commits intohed-standard:mainfrom
VisLab:fix_extras

Conversation

@VisLab
Copy link
Member

@VisLab VisLab commented Feb 26, 2026

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables loading of prerelease library schemas whose withStandard references a prerelease standard schema, by plumbing an opt-in check_prerelease flag through schema loading APIs and the schema-loading test script.

Changes:

  • Add check_prerelease plumbing through load_schema()/from_string() and all schema loader classes so partnered standard lookup can include prerelease cache when enabled.
  • Update hed_check_schema_loading/run_loading_check() to pass check_prerelease=True when testing schemas found under prerelease directories, and add early ValueError validation for conflicting flags.
  • Expand schema roundtrip validation helper to test both merged and unmerged serialization paths; add a small test for conflicting run_loading_check() flags; document behavior in CHANGELOG.md.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
spec_tests/test_loading_schemas.py Adds tests ensuring run_loading_check() rejects mutually exclusive flag combinations.
hed/scripts/schema_script_util.py Refactors schema format roundtrip validation into a helper and runs it for merged/unmerged variants.
hed/scripts/check_schema_loading.py Passes check_prerelease when loading prerelease schemas and adds programmatic flag-conflict validation.
hed/schema/schema_io/xml2schema.py Threads check_prerelease into XML loader constructor/superclass.
hed/schema/schema_io/wiki2schema.py Threads check_prerelease into MediaWiki loader constructor/superclass.
hed/schema/schema_io/json2schema.py Threads check_prerelease into JSON loader constructor/superclass.
hed/schema/schema_io/df2schema.py Threads check_prerelease into TSV/dataframe loader and load_spreadsheet.
hed/schema/schema_io/base2schema.py Stores check_prerelease on the base loader and uses it for withStandard partner resolution.
hed/schema/hed_schema_io.py Adds check_prerelease parameter to load_schema() and from_string() and forwards to loaders.
CHANGELOG.md Documents the new prerelease partnering capability and related API/script changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@VisLab VisLab merged commit 87e08dd into hed-standard:main Feb 26, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants