Add more compliance tests for the extras#1236
Merged
VisLab merged 3 commits intohed-standard:mainfrom Feb 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new schema-compliance checks around “extras” completeness and annotation attribute validity, and updates/extends the test suite to account for warnings vs. errors in compliance output.
Changes:
- Add two new compliance checks:
extras_columnsandannotation_attributes(both treated as warnings). - Expand schema compliance tests to validate these new checks and adjust expectations for known base-schema annotation warnings.
- Update spec tests and schema validation tooling to filter compliance results by
ErrorSeverity.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/schema/test_schema_format_roundtrip.py | Adjusts compliance assertion to only fail on ERROR-severity issues. |
| tests/schema/test_schema_compliance.py | Updates summary expectations and adds test coverage for new extras/annotation compliance checks. |
| spec_tests/test_errors.py | Filters out WARNING compliance issues of a specific code during schema spec tests. |
| spec_tests/hed-tests | Bumps hed-tests submodule revision. |
| hed/scripts/schema_script_util.py | Treats only ERROR-severity compliance issues as validation failures. |
| hed/schema/schema_validation/compliance.py | Implements check_extras_columns and check_annotation_attribute_values; modifies severity handling. |
| hed/errors/schema_error_messages.py | Adds new schema error messages for extras/annotation compliance warnings. |
| hed/errors/error_types.py | Adds new SchemaAttributeErrors constants for extras and annotation checks. |
| .github/workflows/links.yaml | Updates lychee link checker GitHub Action version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.