Skip to content

Add more compliance tests for the extras#1236

Merged
VisLab merged 3 commits intohed-standard:mainfrom
VisLab:fix_extras
Feb 26, 2026
Merged

Add more compliance tests for the extras#1236
VisLab merged 3 commits intohed-standard:mainfrom
VisLab:fix_extras

Conversation

@VisLab
Copy link
Member

@VisLab VisLab commented Feb 25, 2026

No description provided.

@VisLab VisLab requested a review from Copilot February 25, 2026 23:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new schema-compliance checks around “extras” completeness and annotation attribute validity, and updates/extends the test suite to account for warnings vs. errors in compliance output.

Changes:

  • Add two new compliance checks: extras_columns and annotation_attributes (both treated as warnings).
  • Expand schema compliance tests to validate these new checks and adjust expectations for known base-schema annotation warnings.
  • Update spec tests and schema validation tooling to filter compliance results by ErrorSeverity.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
tests/schema/test_schema_format_roundtrip.py Adjusts compliance assertion to only fail on ERROR-severity issues.
tests/schema/test_schema_compliance.py Updates summary expectations and adds test coverage for new extras/annotation compliance checks.
spec_tests/test_errors.py Filters out WARNING compliance issues of a specific code during schema spec tests.
spec_tests/hed-tests Bumps hed-tests submodule revision.
hed/scripts/schema_script_util.py Treats only ERROR-severity compliance issues as validation failures.
hed/schema/schema_validation/compliance.py Implements check_extras_columns and check_annotation_attribute_values; modifies severity handling.
hed/errors/schema_error_messages.py Adds new schema error messages for extras/annotation compliance warnings.
hed/errors/error_types.py Adds new SchemaAttributeErrors constants for extras and annotation checks.
.github/workflows/links.yaml Updates lychee link checker GitHub Action version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@VisLab VisLab merged commit 29bb542 into hed-standard:main Feb 26, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants