This repository was archived by the owner on Jan 24, 2022. It is now read-only.
[springboard] Use LMResponseConsumePropertyList in IPC recieve function#81
Open
leptos-null wants to merge 1 commit intohbang:masterfrom
leptos-null:master
Open
[springboard] Use LMResponseConsumePropertyList in IPC recieve function#81leptos-null wants to merge 1 commit intohbang:masterfrom leptos-null:master
leptos-null wants to merge 1 commit intohbang:masterfrom
leptos-null:master
Conversation
Member
|
I’ll need to recall why I did that instead of using LMResponseConsumePropertyList, it may have been that the logic wasn’t ARC-friendly but I believe those issues were fixed. Could even just be something I forgot to clean up after debugging once many years ago… Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LMResponseConsumePropertyListconverts the given response into a property list, just like theReceivedRelayedNotificationfunction implements. Additionally, this cleans up both thedataandrequest(nowresponsein this PR) being leaked.The
LMResponseBufferstruct is theLMMessagestruct with the buffer padding at the end. Due to C struct layouts, this allows them to be used interchangeably. The size check is still correct.Edit: Here's a link to the implementation of LMResponseConsumePropertyList checked out at the current theos/headers commit