Skip to content

Comments

Fix of #243 (uncomment Pretty instances for {4,5,6,7}-tuple)#275

Merged
sjakobi merged 5 commits intohaskell-prettyprinter:masterfrom
Ei30metry:i243
Feb 24, 2026
Merged

Fix of #243 (uncomment Pretty instances for {4,5,6,7}-tuple)#275
sjakobi merged 5 commits intohaskell-prettyprinter:masterfrom
Ei30metry:i243

Conversation

@Ei30metry
Copy link
Collaborator

@Ei30metry Ei30metry commented Feb 8, 2026

Fix of #243. The code was already there, so I just uncommented it.

…,6,7}-tuple)

The code was already there, so I just uncommented it.
@sjakobi
Copy link
Collaborator

sjakobi commented Feb 8, 2026

since-annotations would be good to have. You can use @since FIXME while the version number is unclear.

I also noticed that we don't seem to have CI with GHC 9.14. It would be good to add this.

@Ei30metry
Copy link
Collaborator Author

since-annotations would be good to have. You can use @since FIXME while the version number is unclear.
Done.

I also noticed that we don't seem to have CI with GHC 9.14. It would be good to add this.
Should I open a new issue for this?

@sjakobi
Copy link
Collaborator

sjakobi commented Feb 8, 2026

I also noticed that we don't seem to have CI with GHC 9.14. It would be good to add this.
Should I open a new issue for this?

I've made a PR: #276

@Ei30metry
Copy link
Collaborator Author

Ei30metry commented Feb 8, 2026

since-annotations would be good to have. You can use @since FIXME while the version number is unclear.

Done.

I also noticed that we don't seem to have CI with GHC 9.14. It would be good to add this.

Should I open a new issue for this?

@Ei30metry
Copy link
Collaborator Author

since-annotations would be good to have. You can use @since FIXME while the version number is unclear.

Done.

I also noticed that we don't seem to have CI with GHC 9.14. It would be good to add this.

Should I open a new issue for this?

I just saw that you have done this.

@sjakobi sjakobi merged commit 84f288d into haskell-prettyprinter:master Feb 24, 2026
16 checks passed
@sjakobi
Copy link
Collaborator

sjakobi commented Feb 24, 2026

Thank you, @Ei30metry! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants