fix: remove float_precision for protobuf 7 #559

daniel-sanche · 2026-01-24T00:51:09Z

Fixes googleapis/google-cloud-python#15099

Protobuf 7 is removing the float_prevision argument. This PR ignores it when passed in 7.x+, and raises a DeprecationWarning

gemini-code-assist · 2026-01-24T00:51:27Z

Summary of Changes

Hello @daniel-sanche, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the library to gracefully manage the breaking change introduced in Protobuf 7, where the float_precision argument was removed. It ensures that the library remains functional across different Protobuf versions by dynamically adapting its behavior based on the detected Protobuf major version, providing a clear deprecation warning for users who might still be passing the removed argument.

Highlights

Protobuf 7 Compatibility: The pull request introduces changes to ensure compatibility with Protobuf version 7, specifically addressing the removal of the float_precision argument.
Version Detection: A mechanism has been added to proto/message.py to extract and store the major version of the installed Protobuf library, allowing for version-specific logic.
Conditional Argument Handling: The to_json and to_dict methods now conditionally handle the float_precision argument. For Protobuf versions 3-6, it is passed through, but for Protobuf 7+, it is ignored.
Deprecation Warning: When float_precision is provided in calls to to_json or to_dict while running on Protobuf 7 or higher, a DeprecationWarning is now issued to inform users of its removal.
Code Refactoring: Common logic for to_json and to_dict has been extracted into a new private helper function _message_to_map to reduce code duplication and centralize version-dependent argument handling.
Test Coverage: New tests have been added to tests/test_json.py and tests/test_message.py to specifically verify the behavior of float_precision with Protobuf 7+, including the emission of the DeprecationWarning.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly addresses the removal of the float_precision argument in Protobuf 7. The approach of ignoring the argument and issuing a DeprecationWarning for newer versions is sound. The refactoring of to_json and to_dict into a shared helper function is a good improvement for code maintainability. I have one minor suggestion to simplify the logic for extracting the Protobuf major version.

proto/message.py

parthea · 2026-01-28T20:56:08Z

@daniel-sanche , Please could you address the failing tests?

proto/message.py

chalmerlowe · 2026-01-30T11:37:40Z

tests/test_json.py


-# TODO: https://github.com/googleapis/proto-plus-python/issues/390
 def test_json_float_precision():
+    if int(proto.message._PROTOBUF_MAJOR_VERSION) >= 7:


NO ACTION:

I situations like this, I often choose to decorate a test with @pytest.mark.parametrize() and include one or more happy paths and sad paths (labeled with IDs for clarity when looking at the pytest results) rather than writing two separate tests. Avoids a lot of duplicate code. Not saying you need to do anything here. Just pointing it out as an option for future tests down the road.

Good point. I think they started out different, but the code is pretty similar now. I'll take another look

chalmerlowe

Approved with suggested fixes for minor spelling and grammar errors.

Also, includes a suggestion for future work, that is not required to be incorporated here (NO ACTION).

parthea · 2026-01-30T16:58:42Z

proto/message.py

+        warnings.warn(warning_msg, DeprecationWarning, stacklevel=3)
+    # supress similar float_precision warning from protobuf library
+    with warnings.catch_warnings():
+        warnings.simplefilter("ignore", category=UserWarning)


One downside of this approach is that we will no longer see new user warnings. For example, in October 2025, https://pypi.org/project/protobuf/6.33.0/ included a new deprecation warning for the float_precision argument, within the same major version. See the release notes for https://github.com/protocolbuffers/protobuf/releases/tag/v33.0-rc1

Can we use warnings.filterwarnings to narrow down the warnings that are filtered to the one that includes the text float_precision?

warnings.filterwarnings("ignore", message=".*float_precision.*")

good point, fixed

Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>

pytest.ini

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

daniel-sanche added 7 commits January 23, 2026 15:08

fix: ignore float_precision in protobuf 7.x

bcd7ecd

fixed implementation

a27845c

refactored into shared helper

d946a7a

moved _to_map outside class

89e5ac2

improved PROTOBUF_VERSION in prep for 10+

41c8499

updated test

3b4a2e0

improved tests

638c8f6

daniel-sanche requested a review from a team as a code owner January 24, 2026 00:51

gemini-code-assist bot reviewed Jan 24, 2026

View reviewed changes

proto/message.py Outdated Show resolved Hide resolved

daniel-sanche added 3 commits January 23, 2026 16:54

fixed style

e6ef3c7

added no cover

944c570

use partition instead of find

586cb92

parthea reviewed Jan 26, 2026

View reviewed changes

proto/message.py Outdated Show resolved Hide resolved

daniel-sanche added 3 commits January 27, 2026 13:56

separate warning messages

9a24832

reverted to only warning for removal

6672f08

updated tests

e76ad73

daniel-sanche added 3 commits January 29, 2026 14:24

fix tests

ae854bf

suppress protobuf warning and raise our own

e14707c

fixed style

18e10e8

chalmerlowe reviewed Jan 30, 2026

View reviewed changes

proto/message.py Outdated Show resolved Hide resolved

chalmerlowe reviewed Jan 30, 2026

View reviewed changes

proto/message.py Outdated Show resolved Hide resolved

chalmerlowe reviewed Jan 30, 2026

View reviewed changes

chalmerlowe approved these changes Jan 30, 2026

View reviewed changes

parthea reviewed Jan 30, 2026

View reviewed changes

daniel-sanche and others added 4 commits January 30, 2026 09:50

Apply suggestions from code review

3a96248

Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>

filter based on message

2359c2d

fixed filter warnings

78e201d

simplified tests

5bd83d3

daniel-sanche added 3 commits January 30, 2026 10:20

fixed ids

c7093ff

fixed test issue

d5d6d52

fixed style

6689172

parthea approved these changes Jan 30, 2026

View reviewed changes

pytest.ini Outdated Show resolved Hide resolved

chalmerlowe mentioned this pull request Jan 30, 2026

fix: filter sphinx warnings related to adding a new line after lists googleapis/gapic-generator-python#2533

Merged

Update pytest.ini

f849127

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea approved these changes Jan 30, 2026

View reviewed changes

daniel-sanche merged commit 390b9d5 into main Jan 30, 2026
34 checks passed

daniel-sanche deleted the fix_proto_7 branch January 30, 2026 19:31

daniel-sanche mentioned this pull request Jan 30, 2026

chore: librarian release pull request: 20260130T125408Z #560

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: remove float_precision for protobuf 7 #559

fix: remove float_precision for protobuf 7 #559

Uh oh!

daniel-sanche commented Jan 24, 2026

Uh oh!

gemini-code-assist bot commented Jan 24, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

parthea commented Jan 28, 2026

Uh oh!

Uh oh!

Uh oh!

chalmerlowe Jan 30, 2026

Uh oh!

daniel-sanche Jan 30, 2026 •

edited

Loading

Uh oh!

chalmerlowe left a comment •

edited

Loading

Uh oh!

parthea Jan 30, 2026 •

edited

Loading

Uh oh!

daniel-sanche Jan 30, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: remove float_precision for protobuf 7 #559

fix: remove float_precision for protobuf 7 #559

Uh oh!

Conversation

daniel-sanche commented Jan 24, 2026

Uh oh!

gemini-code-assist bot commented Jan 24, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

parthea commented Jan 28, 2026

Uh oh!

Uh oh!

Uh oh!

chalmerlowe Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

daniel-sanche Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chalmerlowe left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parthea Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daniel-sanche Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

daniel-sanche Jan 30, 2026 •

edited

Loading

chalmerlowe left a comment •

edited

Loading

parthea Jan 30, 2026 •

edited

Loading