Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google-cloud-spanner-bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.14.1</version>
<version>3.15.0</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency and avoid hardcoding the version in multiple places, this version should also be replaced with the property defined in the parent pom.xml (${maven-compiler-plugin.version}). This will make future updates easier.

Suggested change
<version>3.15.0</version>
<version>${maven-compiler-plugin.version}</version>

<configuration>
<source>1.8</source>
<target>1.8</target>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.14.1</version>
<version>3.15.0</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid version duplication, it's a good practice to manage the version of this plugin using a property. This ensures that the version is consistent across all modules and only needs to be updated in one place.

Please add the following property to the <properties> section of this pom.xml:

<maven-compiler-plugin.version>3.15.0</maven-compiler-plugin.version>

Then, you can use the property here.

Suggested change
<version>3.15.0</version>
<version>${maven-compiler-plugin.version}</version>

<configuration>
<source>1.8</source>
<target>1.8</target>
Expand Down
Loading