-
Notifications
You must be signed in to change notification settings - Fork 138
build(deps): update dependency org.apache.maven.plugins:maven-compiler-plugin to v3.15.0 #4325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -152,7 +152,7 @@ | |||||
| <plugin> | ||||||
| <groupId>org.apache.maven.plugins</groupId> | ||||||
| <artifactId>maven-compiler-plugin</artifactId> | ||||||
| <version>3.14.1</version> | ||||||
| <version>3.15.0</version> | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To improve maintainability and avoid version duplication, it's a good practice to manage the version of this plugin using a property. This ensures that the version is consistent across all modules and only needs to be updated in one place. Please add the following property to the <maven-compiler-plugin.version>3.15.0</maven-compiler-plugin.version>Then, you can use the property here.
Suggested change
|
||||||
| <configuration> | ||||||
| <source>1.8</source> | ||||||
| <target>1.8</target> | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To maintain consistency and avoid hardcoding the version in multiple places, this version should also be replaced with the property defined in the parent
pom.xml(${maven-compiler-plugin.version}). This will make future updates easier.