feat: Add GcRuleBuilder for safe GC rule construction #2758
+307
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
jinseopkim0
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
jinseopkim0
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
lqiu96
reviewed
Jan 21, 2026
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/GcRuleBuilder.java
Outdated
Show resolved
Hide resolved
lqiu96
reviewed
Jan 21, 2026
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/GcRuleBuilder.java
Outdated
Show resolved
Hide resolved
lqiu96
reviewed
Jan 21, 2026
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/GcRuleBuilder.java
Outdated
Show resolved
Hide resolved
lqiu96
reviewed
Jan 21, 2026
...loud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/GcRuleBuilderTest.java
Show resolved
Hide resolved
product-auto-label
bot
added
size: l
jinseopkim0
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
lqiu96
reviewed
Jan 21, 2026
Comment on lines
+40
to
+51
| public static IntersectionRuleBuilder intersection() { | ||
| return new IntersectionRuleBuilder(); | ||
| } | ||
|
|
||
| /** | ||
| * Starts building a Union (OR) rule. | ||
| * | ||
| * @return A new builder for a union rule. | ||
| */ | ||
| public static UnionRuleBuilder union() { | ||
| return new UnionRuleBuilder(); | ||
| } |
Member
There was a problem hiding this comment.
nit: Have we considered naming like:
- GcRuleUnionBuilder
- GcRuleIntersectionBuilder
I think it may be clearer for users that these are specifically for GcRules. I guess that in the context it will generally be:
GcRuleBuilder.union().addRule(...)
or
UnionRuleBuilder ruleBuilder = GcRuleBuilder.union();
ruleBuilder.add(...)
which is also pretty clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
GcRuleBuilderand associated helpers to provide a type-safe way to construct Bigtable Garbage Collection rules.Changes:
GcRuleBuilderfactory to prevent silent overwrites ofoneoffields (e.g., accidentally setting bothmax_ageandmax_versions).IntersectionandUnionrules (IntersectionRuleBuilder,UnionRuleBuilder).GcRuleBuilderTestto verify correct proto construction.Context:
This addresses the "Garbage Collection Rules" Critical User Journey (CUJ) for the Admin API modernization.
Tracking Bug:
b/475818580