-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: librarian update image pull request: 20260126T232545Z #15487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…prod/images-prod/python-librarian-generator@sha256:56f26eaebaf1b4a9f174a72e00d091a1364997e17201dbad1aea099ddbda3a3e
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs two distinct updates: a routine update of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is an automated update for the python-librarian-generator image, reflected in the .librarian/state.yaml file. This update has resulted in the addition of typing.Any to the imports of numerous generated Python files. While this is an automated change, I've added a single representative comment highlighting that using Any weakens type safety. This is a general concern for all files modified in this way and ideally should be addressed in the generator itself to improve long-term code quality and maintainability.
| # | ||
| import abc | ||
| from typing import Awaitable, Callable, Dict, Optional, Sequence, Union | ||
| from typing import Any, Awaitable, Callable, Dict, Optional, Sequence, Union |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The introduction of typing.Any weakens type safety, as it effectively disables type checking for any expression it's used with. While this change is part of an automated generator update, it's a step back for static analysis and code maintainability. It would be best if the generator could produce more specific types. This comment applies to all other files in this PR with the same change.
feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:56f26eaebaf1b4a9f174a72e00d091a1364997e17201dbad1aea099ddbda3a3e
docspresubmit failure.7.34.0rc1pre-release proto-plus-python#558 for theprereleasepresubmit failure