-
Notifications
You must be signed in to change notification settings - Fork 661
Add android track event for surfaceflinger workloads #4276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Also add a corresponding sql table in the stdlib so that writing queries is ezpz.
🎨 Perfetto UI Build✅ UI build is ready: https://storage.googleapis.com/perfetto-ci-artifacts/gh-20835627401-1-ui/ui/index.html |
src/trace_processor/perfetto_sql/stdlib/android/surfaceflinger.sql
Outdated
Show resolved
Hide resolved
src/trace_processor/perfetto_sql/stdlib/android/surfaceflinger.sql
Outdated
Show resolved
Hide resolved
src/trace_processor/perfetto_sql/stdlib/android/surfaceflinger.sql
Outdated
Show resolved
Hide resolved
src/trace_processor/perfetto_sql/stdlib/android/surfaceflinger.sql
Outdated
Show resolved
Hide resolved
src/trace_processor/perfetto_sql/stdlib/android/surfaceflinger.sql
Outdated
Show resolved
Hide resolved
LalitMaganti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice if there was a diff test for this to ensure we don't break this especially if you plan on relying on this longer term but up to you. You can also add it later once the other side is more settled.
| extract_arg(arg_set_id, 'surfaceflinger_workload.summary.stats.dpu_composited_layers') AS dpu_composited_layers | ||
| FROM slice | ||
| WHERE | ||
| category = 'rendering' AND name = 'WorkloadSummary'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have the name filter, you probably don't need the category one anymore. But up to you, probably won't hurt too much
Also add a corresponding sql table in the stdlib so that writing queries is ezpz.
This is going to be used for allowing traces + analysis tools to measure SurfaceFlinger workload behavior.