Decouple unit tests from hilt and robolectric

[andreia-ferreira]

This PR removes unnecessary BaseHiltTest and Robolectric usage from several unit tests (mainly UseCases) that had no real dependency on Android or DI infrastructure.

The changes include:

• Created the testrules package and moved the FragmentScenarioRule there
• Fixed TestCoroutineDispatchersModule to not provide a static test dispatcher which meant the same dispatcher instance was shared for the entire test run. This could cause leftover coroutine state from one test class to leak into another

Overall, this reduces boilerplate and Android-specific infrastructure in the tests and moves them closer to being KMP-compatible, with no significant impact on test runtime

@shobhitagarwal1612 PTAL?

[gemini-code-assist]

Summary of Changes

Hello @andreia-ferreira, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the quality and maintainability of unit tests by reducing their reliance on Android-specific frameworks like Hilt and Robolectric. By decoupling tests, the codebase becomes more KMP-compatible and reduces boilerplate, leading to more focused and reliable tests.

Highlights

• Test Decoupling: This PR decouples unit tests from Hilt and Robolectric, reducing dependencies on Android-specific infrastructure.
• Coroutine Dispatcher Handling: It introduces MainDispatcherRule to manage coroutine dispatcher setup in tests, ensuring proper isolation and preventing state leakage.
• Test Rule Management: The FragmentScenarioRule was moved to the testrules package for better organization.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Activity

• The PR introduces testrules package and moves FragmentScenarioRule there.
• It adds MainDispatcherRule to handle coroutine dispatcher setup.
• It fixes TestCoroutineDispatchersModule to avoid sharing the same dispatcher instance across test runs.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request successfully decouples several unit tests from Hilt and Robolectric, which is a great step toward improving test performance and moving closer to Kotlin Multiplatform (KMP) compatibility. The introduction of MainDispatcherRule and the improvements to TestCoroutineDispatchersModule for better test isolation are particularly valuable. I have identified a few instances where runTest should explicitly use the dispatcher from MainDispatcherRule to ensure that the test body and the code under test share the same scheduler, which is essential for reliable virtual time control.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.03%. Comparing base (6a107dc) to head (9b2b0f9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #3580   +/-   ##
=========================================
  Coverage     71.03%   71.03%           
  Complexity     1631     1631           
=========================================
  Files           331      331           
  Lines          8956     8956           
  Branches        998      998           
=========================================
  Hits           6362     6362           
  Misses         1998     1998           
  Partials        596      596           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.