Adding MulticastAppDelegate#68
Merged
charlotteliang merged 12 commits intochar-multicast-featurefrom Feb 2, 2022
Merged
Conversation
Coverage Report 1Affected ProductsNo changes between base commit (b3bb0c5) and merge commit (1158a7d).Test Logs |
paulb777
reviewed
Jan 26, 2022
Member
paulb777
left a comment
paulb777
left a comment
There was a problem hiding this comment.
Do you plan to add unit tests and CI?
GoogleMulticastAppDelegate/Apps/SwiftUISample/SwiftUISample/MulticastAppDelegate.swift
Outdated
Show resolved
Hide resolved
charlotteliang
commented
Jan 26, 2022
GoogleMulticastAppDelegate/Sources/Public/GoogleUtilities/GULMulticastAppDelegate.h
Outdated
Show resolved
Hide resolved
ncooke3
reviewed
Jan 31, 2022
Member
ncooke3
left a comment
ncooke3
left a comment
There was a problem hiding this comment.
Nice! Leaving some questions and suggestions:
GoogleMulticastAppDelegate/Tests/Unit/GULMulticastAppDelegateTest.m
Outdated
Show resolved
Hide resolved
GoogleMulticastAppDelegate/Sources/Public/GoogleUtilities/GULMulticastAppDelegate.h
Show resolved
Hide resolved
GoogleMulticastAppDelegate/Sources/Public/GoogleUtilities/GULMulticastAppDelegate.h
Outdated
Show resolved
Hide resolved
ncooke3
approved these changes
Feb 2, 2022
paulb777
reviewed
Feb 2, 2022
Member
paulb777
left a comment
paulb777
left a comment
There was a problem hiding this comment.
Perhaps, this should be merged to a branch instead of main.
I see at least four outstanding issues
- Still needs a Package.swift update
- Multi-platform support
- Integration testing from a podspec deployed to SpecsTesting
- test specs
charlotteliang
changed the title
Contributor
Author
|
Yep, will do a series of more PRs to the feature branch so this one won't get large. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be a feature branch after this PR approval, this PR just mimics the oiginal implementation: #50.
I will check out subbranch from here to continue work on SceneDelegate support for auth and UNUserNotificationCenterDelegate for messaging