Vary lint:js log message based on context#115
Open
agibson-godaddy wants to merge 1 commit intomasterfrom
Open
Conversation
8 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves user experience by varying the JavaScript linting log message based on execution context. When running sake lint:js directly, the message simply reports errors and warnings. When running as part of sake build, the message additionally mentions the --fail-on-lint-errors flag option, which is more relevant in the build context.
Changes:
- Added conditional logic to display context-appropriate log messages based on whether the linting is part of a build task
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #106 (comment)
This varies the log message based on whether we're running the build task.
QA
sake lint:jssake build