Skip to content

Vary lint:js log message based on context#115

Open
agibson-godaddy wants to merge 1 commit intomasterfrom
fix/js-linting-error-message
Open

Vary lint:js log message based on context#115
agibson-godaddy wants to merge 1 commit intomasterfrom
fix/js-linting-error-message

Conversation

@agibson-godaddy
Copy link
Contributor

Follow-up to #106 (comment)

This varies the log message based on whether we're running the build task.

QA

  1. Run sake lint:js
    • Output doesn't mention building
    image
  2. Run sake build
    • Output mentions building / halting on errors
    image

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves user experience by varying the JavaScript linting log message based on execution context. When running sake lint:js directly, the message simply reports errors and warnings. When running as part of sake build, the message additionally mentions the --fail-on-lint-errors flag option, which is more relevant in the build context.

Changes:

  • Added conditional logic to display context-appropriate log messages based on whether the linting is part of a build task

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant