This repository was archived by the owner on Aug 17, 2020. It is now read-only.
Fix reading and writing of the results at the same time#197
Open
n1koo wants to merge 1 commit intogoadapp:masterfrom
Open
Fix reading and writing of the results at the same time#197n1koo wants to merge 1 commit intogoadapp:masterfrom
n1koo wants to merge 1 commit intogoadapp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation doesn't work with Go1.6+ (probably, atleast 1.8) because
mapis not thread safe. I dont think it ever was but modern versions just detect it better.This PR wraps the reading of the results for printout and updating of them in mutexes. Tested on Go 1.11
Snippet of the problem