fix(docker): add git fetch --tags for versioned builds#12
Open
breezytm wants to merge 2 commits intogiwa-io:mainfrom
Open
fix(docker): add git fetch --tags for versioned builds#12breezytm wants to merge 2 commits intogiwa-io:mainfrom
breezytm wants to merge 2 commits intogiwa-io:mainfrom
Conversation
The build was failing with the error: ```error: pathspec 'v1.101603.1' did not match any file(s) known to git``` This occurred because `git clone` does not fetch all tags by default, and the tag `v1.101603.1` was not available in the local repository context. To fix this, added `git fetch --tags` before the checkout and used the explicit `tags/` namespace to ensure the tag is recognized.
Resolved an error during the Docker build: ```error: pathspec 'op-node/v1.14.1' did not match any file(s) known to git``` This was caused by attempting to checkout a tag before fetching all tags from the remote repository. By default, `git clone` does not retrieve all tags unless explicitly requested. Added `git fetch --tags` before the checkout command and used the full tag path `tags/op-node/$OPNODE_VERSION` to ensure the reference is correctly resolved.
ihooni
requested changes
Oct 23, 2025
| ARG OPGETH_VERSION | ||
|
|
||
| RUN git checkout $OPGETH_VERSION | ||
| RUN git fetch --tags && git checkout "tags/${OPGETH_VERSION}" |
Collaborator
There was a problem hiding this comment.
how about clone with single branch?
> git clone https://github.com/ethereum-optimism/op-geth.git --branch v1.101603.1 --single-branch
Author
There was a problem hiding this comment.
Yes, it should work
RUN git clone --branch ${OPGETH_VERSION} --single-branch https://github.com/ethereum-optimism/op-geth.git
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The Docker build was failing during git checkout due to missing Git tags:
Solution
This issue occurred because
git clonedoes not automatically fetch all tags, especially when the tags are lightweight or not associated with the default branch. As a result, the requested tag could not be found duringcheckout.To resolve this, we explicitly fetch all tags before checking out the version and use the full
tags/<tag>path to ensure Git interprets it correctly.Changes