Enable polynomial ReDoS query to use plain regex-use sinks
#21115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The polynomial ReDoS query couldn't detect vulnerabilities in Apache Commons Lang3
RegExUtilsmethods because they use the plainregex-usesink kind, whileregexSinkKindInfoonly parsed bracketed forms likeregex-use[0].Changes
regexSinkKindInfopredicate to handle plainregex-usewith defaults: non-full-string matching, string argument at index 0org.apache.commons.lang3.model.ymlto document the behaviorRegExUtilsmethods in polynomial ReDoS test suiteTechnical Details
The plain
regex-usekind is used by methods where both pattern and input are provided in a single call, likeRegExUtils.removeAll(text, regex). The defaults (full=false,strArg=0) match this signature pattern where the regex is atArgument[1]and the text to match is atArgument[0].This preserves the existing behavior where regex injection and polynomial ReDoS queries select different sink kinds to avoid false positives, while enabling the ReDoS query to analyze these methods.
Original prompt
Created from VS Code via the GitHub Pull Request extension.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.