All languages: account for paths and paths-ignore in XML and other ancillary extraction #21102
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cillary extraction
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for code-scanning-config paths and paths-ignore directives to ancillary data extraction (XML, YAML, HTML) across multiple language extractors, mirroring the Java implementation from PR #21049.
- Adds the
--also-match-lgtm-index-filtersflag tocodeql database index-filescommands - Ensures consistent behavior across Go, Python, C#, and QL-for-QL extractors
- Updates both Unix shell scripts and Windows command scripts for each language
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ql/tools/pre-finalize.sh | Adds --also-match-lgtm-index-filters flag to YAML file indexing for QL extractor (Unix) |
| ql/tools/pre-finalize.cmd | Adds --also-match-lgtm-index-filters flag to YAML file indexing for QL extractor (Windows) |
| python/tools/pre-finalize.sh | Adds --also-match-lgtm-index-filters flag to YAML file indexing for Python extractor (Unix) |
| python/tools/pre-finalize.cmd | Adds --also-match-lgtm-index-filters flag to YAML file indexing for Python extractor (Windows) |
| go/codeql-tools/pre-finalize.sh | Adds --also-match-lgtm-index-filters flag to HTML file indexing for Go extractor (Unix) |
| go/codeql-tools/pre-finalize.cmd | Adds --also-match-lgtm-index-filters flag to HTML file indexing for Go extractor (Windows) |
| csharp/tools/pre-finalize.sh | Adds --also-match-lgtm-index-filters flag to XML file indexing for C# extractor (Unix) |
| csharp/tools/pre-finalize.cmd | Adds --also-match-lgtm-index-filters flag to XML file indexing for C# extractor (Windows) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
owen-mc
approved these changes
Jan 6, 2026
Contributor
Author
|
Don't merge for now: this causes a regression when |
Contributor
Author
|
The regression has been resolved by an internal PR. |
smowton
deleted the
smowton/admin/respect-config-paths-filters-pre-finalize
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go, Python, C# and QL-for-QL: mirror Java in accounting for code-scanning-config
pathsandpaths-ignoredirectives when extracting XML and other ancillary data.I haven't added integration tests because they would be materially identical to the ones added in #21049