Java: allow MaD barriers #21055
Merged
Java: allow MaD barriers #21055
+37
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
java/ql/lib/semmle/code/java/security/AndroidSensitiveCommunicationQuery.qll
Fixed
Show fixed
Hide fixed
java/ql/lib/semmle/code/java/security/ExternallyControlledFormatStringQuery.qll
Fixed
Show fixed
Hide fixed
owen-mc
force-pushed
the
java/allow-mad-barriers
branch
from
f928943 to
766e908
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables users to add query-specific sanitizers using data extensions (MaD) by renaming existing sanitizer classes from "Default" to "External" and adding missing abstract sanitizer classes where needed.
Key changes:
- Rename five existing
Default*Sanitizerclasses toExternal*Sanitizerto better reflect their purpose as externally-defined MaD barriers - Add three new abstract sanitizer classes (
GroovyInjectionSanitizer,FragmentInjectionSanitizer) with corresponding external implementations - Add
isBarrierpredicate toFragmentInjectionTaintConfigto properly integrate the new sanitizer class
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| RegexInjection.qll | Rename DefaultRegexInjectionSanitizer to ExternalRegexInjectionSanitizer |
| XSS.qll | Rename DefaultXssSanitizer to ExternalXssSanitizer |
| TrustBoundaryViolationQuery.qll | Rename DefaultTrustBoundaryValidationSanitizer to ExternalTrustBoundaryValidationSanitizer |
| RequestForgery.qll | Rename DefaultRequestForgerySanitizer to ExternalRequestForgerySanitizer |
| PathSanitizer.qll | Rename DefaultPathInjectionSanitizer to ExternalPathInjectionSanitizer |
| GroovyInjection.qll | Add abstract GroovyInjectionSanitizer class and ExternalGroovyInjectionSanitizer implementation |
| FragmentInjectionQuery.qll | Add isBarrier predicate to properly use the new sanitizer class |
| FragmentInjection.qll | Add abstract FragmentInjectionSanitizer class and ExternalFragmentInjectionSanitizer implementation |
| CommandLineQuery.qll | Add ExternalCommandInjectionSanitizer class (abstract class already existed) |
| AndroidIntentRedirection.qll | Add ExternalIntentRedirectionSanitizer class (abstract class already existed) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
java/ql/lib/semmle/code/java/security/AndroidIntentRedirection.qll
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds classes so users can add query-specific sanitizers using data extensions ("models-as-data", or MaD), using the same
kindstrings as already used by sinks. This follows on from the PR where existing sanitizers were converted to MaD.