Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project's ESLint configuration from the legacy .eslintrc.json format to the new flat config system (eslint.config.js) required by ESLint v9, and bumps several npm dependencies to their latest versions. The version string is also incremented to v11.1.3 in preparation for release.
- Migrated from
.eslintrc.json+.eslintignoretoeslint.config.js(flat config) - Updated dependencies:
@actions/core,@octokit/*packages, and dev dependencies likeeslint,vitest,prettier - Incremented version to v11.1.3
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/version.js | Bumped version string from v11.1.2 to v11.1.3 |
| package.json | Updated multiple dependencies and devDependencies to latest versions |
| eslint.config.js | Added new flat config file with ESM syntax, node/vitest globals, and centralized ignores |
| .eslintrc.json | Removed legacy ESLint configuration file |
| .eslintignore | Removed legacy ESLint ignore file |
| import js from '@eslint/js' | ||
| import globals from 'globals' |
There was a problem hiding this comment.
The imports reference packages @eslint/js and globals that are not declared in package.json dependencies or devDependencies. These packages need to be added to devDependencies for the flat config to function properly.
There was a problem hiding this comment.
Works on my machine 😂
When CI runs it should let us know if this is actually an issue or not. If CI passes just fine, then this can be safely ignored.
|
Works in my sandbox repo: 
Logs: https://github.com/GrantBirki/actions-sandbox/actions/runs/20666124996/job/59338659309 |
|
@nobe4 would you be able to go through the following?
I added that ^ snippet to the PR body. Since this PR changed the resulting artifacts, a new release needs to be sent out for folks to pick up those changes. Thanks! 🙇 |
2 participants
This pull request updates the project's ESLint configuration to use the new flat config system introduced in ESLint v9, removes the old config files, and updates several internal npm dependencies to their latest versions.
This PR directly replaces #440 so after it merges, #440 can just be closed/deleted.
After merging this PR, the release process will need to be followed: https://github.com/github/branch-deploy/blob/main/docs/maintainer-guide.md
This process will: Create a new tag, a new github release, and run the workflow which points
v11.1.3->v11(the convenience tag)Tagging in @nobe4 as my maintainer buddy ❤️