-
Notifications
You must be signed in to change notification settings - Fork 4
Fix CI #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR pins the Python version used in the Pyright type checking workflow from the latest 3.x to a specific version 3.12.
- Changed the Python version specification from '3.x' to '3.12' in the pyright.yaml workflow
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/pyright.yaml
Outdated
| uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: '3.x' | ||
| python-version: '3.12' |
Copilot
AI
Nov 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The pytest workflow uses a matrix strategy to test against Python versions 3.9, 3.10, 3.11, 3.12, and 3.13, while the project supports Python >=3.6 (per pyproject.toml). Pinning pyright to only Python 3.12 means type checking won't catch type issues specific to other supported versions. Consider testing type checking against the minimum supported version (3.6 or 3.9) to ensure backward compatibility, or against multiple versions if version-specific type behaviors are a concern.
See below for a potential fix:
strategy:
matrix:
python-version: [3.6, 3.9, 3.10, 3.11, 3.12, 3.13]
steps:
- uses: actions/checkout@v5
- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: ${{ matrix.python-version }}
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
|
The publish to pypi job is failing because there is another PR that's already pushed the 1.3.2 version. I don't think it's worth bumping the version again just to make that job pass. |
CI is pulling 3.14 now and it's causing CI to fail. Based on the investigation in #99 it appears that a combination of dropping 3.9 support (as it's EoL) and removing
mutmutsolves the issues (it was the only reason we were includinglibcst, which was having the issue, also, there is a new version oflibcstthat supports python 3.14 that we could have updated to if we neededmutmut).mutmuthasn't been an active part of the dev cycle for a while as I had started to have issues with it in CI, but I'd intended to get back to it. Since I haven't yet we can remove it and add it back if time allows for it.