Skip to content

Conversation

@mstv
Copy link
Member

@mstv mstv commented Feb 1, 2026

Fixes search hit being hidden by HScrollBar, also seen with git-grep

Proposed changes

  • TextView.FirstVisibleLine: Replace setter with SetFirstVisibleLine
    which considers possibleHeightLoss because the horizontal scrollbar might become visible
  • TextAreaControl.ScrollTo: Calculate completelyVisibleLinesCount and consider that the horizontal scrollbar might become visible

Screenshots

STR:

  • select commit ae1340d3614c5affab0d828946c44e5e694d4bcd
  • select file src/app/GitUI/UserControls/FileStatusDiffCalculator.cs
  • search for "without HEAD"

Before

image

After

image

@mstv mstv self-assigned this Feb 1, 2026
@mstv mstv merged commit d7894fd into master Feb 3, 2026
3 checks passed
@mstv mstv deleted the fix/vscroll_vs_hscrollbar branch February 3, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants