feat(tracing): Add sentry-span-attributes prop for custom span attributes #5569
+315
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@sentry review |
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
|
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 818a608 | 495.84 ms | 498.08 ms | 2.25 ms |
| a06e222+dirty | 434.00 ms | 439.35 ms | 5.35 ms |
| 180638b+dirty | 408.87 ms | 432.04 ms | 23.17 ms |
| d916aa3 | 425.37 ms | 427.02 ms | 1.65 ms |
| 5ee3314+dirty | 415.80 ms | 426.14 ms | 10.34 ms |
| f234eb4+dirty | 407.62 ms | 429.64 ms | 22.02 ms |
| a2bb688+dirty | 409.65 ms | 410.45 ms | 0.80 ms |
| a206511+dirty | 424.28 ms | 474.82 ms | 50.54 ms |
| 46bd012 | 387.09 ms | 404.47 ms | 17.38 ms |
| 083f560+dirty | 358.21 ms | 382.00 ms | 23.79 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 818a608 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| a06e222+dirty | 43.75 MiB | 48.55 MiB | 4.80 MiB |
| 180638b+dirty | 43.75 MiB | 48.08 MiB | 4.33 MiB |
| d916aa3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 5ee3314+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| f234eb4+dirty | 17.75 MiB | 19.74 MiB | 1.99 MiB |
| a2bb688+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| a206511+dirty | 43.75 MiB | 48.07 MiB | 4.32 MiB |
| 46bd012 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 083f560+dirty | 17.75 MiB | 19.70 MiB | 1.96 MiB |
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a06e222+dirty | 377.17 ms | 401.40 ms | 24.23 ms |
| 180638b+dirty | 434.46 ms | 470.90 ms | 36.44 ms |
| 64cd15c+dirty | 488.79 ms | 483.54 ms | -5.24 ms |
| c08359e+dirty | 406.04 ms | 428.87 ms | 22.83 ms |
| 1226664+dirty | 377.65 ms | 453.94 ms | 76.29 ms |
| 46da307+dirty | 356.62 ms | 415.02 ms | 58.40 ms |
| 7480abe+dirty | 363.80 ms | 431.34 ms | 67.54 ms |
| a206511+dirty | 331.54 ms | 356.98 ms | 25.44 ms |
| 7be1f99+dirty | 369.02 ms | 399.60 ms | 30.58 ms |
| f234eb4+dirty | 313.23 ms | 333.31 ms | 20.08 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a06e222+dirty | 43.94 MiB | 49.38 MiB | 5.44 MiB |
| 180638b+dirty | 43.94 MiB | 48.91 MiB | 4.97 MiB |
| 64cd15c+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| c08359e+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 1226664+dirty | 7.15 MiB | 8.46 MiB | 1.30 MiB |
| 46da307+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 7480abe+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| a206511+dirty | 43.94 MiB | 48.90 MiB | 4.96 MiB |
| 7be1f99+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| f234eb4+dirty | 7.15 MiB | 8.46 MiB | 1.30 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9bf5446+dirty | 1218.60 ms | 1210.45 ms | -8.15 ms |
| d751a5d+dirty | 1212.22 ms | 1217.94 ms | 5.71 ms |
| 88890fe+dirty | 1219.00 ms | 1222.08 ms | 3.08 ms |
| f081f58+dirty | 1208.37 ms | 1215.56 ms | 7.19 ms |
| 0dff710+dirty | 1194.90 ms | 1196.15 ms | 1.25 ms |
| 5c16cdc+dirty | 1235.67 ms | 1241.18 ms | 5.51 ms |
| 5602cc4+dirty | 1204.83 ms | 1212.47 ms | 7.64 ms |
| c08359e+dirty | 1200.59 ms | 1211.81 ms | 11.22 ms |
| 000da7a+dirty | 1204.50 ms | 1218.94 ms | 14.44 ms |
| c1573b3+dirty | 1245.69 ms | 1245.48 ms | -0.21 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9bf5446+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| d751a5d+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| 88890fe+dirty | 3.19 MiB | 4.57 MiB | 1.38 MiB |
| f081f58+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 0dff710+dirty | 3.44 MiB | 4.59 MiB | 1.15 MiB |
| 5c16cdc+dirty | 3.19 MiB | 4.53 MiB | 1.34 MiB |
| 5602cc4+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| c08359e+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 000da7a+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| c1573b3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9bf5446+dirty | 1206.20 ms | 1206.69 ms | 0.48 ms |
| d751a5d+dirty | 1215.57 ms | 1220.56 ms | 4.99 ms |
| 88890fe+dirty | 1219.20 ms | 1231.00 ms | 11.80 ms |
| f081f58+dirty | 1219.10 ms | 1217.57 ms | -1.53 ms |
| 0dff710+dirty | 1207.23 ms | 1203.26 ms | -3.97 ms |
| 5c16cdc+dirty | 1209.32 ms | 1210.67 ms | 1.35 ms |
| 5602cc4+dirty | 1216.49 ms | 1211.58 ms | -4.91 ms |
| c08359e+dirty | 1235.25 ms | 1233.96 ms | -1.29 ms |
| 000da7a+dirty | 1214.31 ms | 1221.91 ms | 7.61 ms |
| c1573b3+dirty | 1203.33 ms | 1202.47 ms | -0.86 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9bf5446+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| d751a5d+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| 88890fe+dirty | 2.63 MiB | 4.00 MiB | 1.37 MiB |
| f081f58+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 0dff710+dirty | 3.44 MiB | 4.59 MiB | 1.15 MiB |
| 5c16cdc+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
| 5602cc4+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| c08359e+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 000da7a+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| c1573b3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
|
This is amazing! Thank you @antonis! |
alwx
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Implements support for adding custom attributes to user interaction spans via the sentry-span-attributes prop. This allows users to add contextual metadata to touch events without manually implementing onPress handlers.
Docs PR: getsentry/sentry-docs#16134
💡 Motivation and Context
Fixes #5511
💚 How did you test it?
Manual with the sample app, Unit tests
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps