fix(integrations): google-genai: reworked gen_ai.request.messages extraction from parameters
#5275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
… if mime_type and file_uri are present (Cursor comment)
Base automatically changed from
constantinius/fix/redact-message-parts-type-blob
to
master
January 13, 2026 09:56
…i-report-image-inputs
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧Release
Other
🤖 This preview updates automatically when you update the PR. |
…i-report-image-inputs
sentrivana
reviewed
Jan 14, 2026
Comment on lines
387
to
397
| if isinstance(function_response, dict): | ||
| tool_call_id = function_response.get("id") | ||
| tool_name = function_response.get("name") | ||
| response_dict = function_response.get("response") or {} | ||
| # Prefer "output" key if present, otherwise use entire response | ||
| output = response_dict.get("output", response_dict) | ||
| else: | ||
| # FunctionResponse object | ||
| tool_call_id = getattr(function_response, "id", None) | ||
| tool_name = getattr(function_response, "name", None) | ||
| response_obj = getattr(function_response, "response", None) or {} |
Contributor
There was a problem hiding this comment.
I've seen this .get() vs getattr pattern a lot in our AI integrations. Feels like introducing a helper function that would try both at once would potentially deduplicate a lot of code.
Not something that needs to be done in this PR, mostly thinking out loud.
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| assert blob_part["type"] == "blob" | ||
| assert blob_part["mime_type"].startswith("image/") | ||
| assert "content" in blob_part | ||
| assert blob_part["content"].startswith("data:image/") |
There was a problem hiding this comment.
Test expects data URL but code returns placeholder
Medium Severity
The test test_extract_contents_messages_pil_image asserts that blob_part["content"].startswith("data:image/"), but the _extract_pil_image function returns BLOB_DATA_SUBSTITUTE which is defined as "[Blob substitute]". This assertion will fail when the test runs (when PIL is available and genai_types.PIL_Image exists).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we only extracted only text parts were extracted. Now the full range of possibilities are covered.
Issues
Closes https://linear.app/getsentry/issue/TET-1638/redact-images-google-genai