fix(litellm): fix gen_ai.request.messages to be as expected
#5255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
…inal messages and handle data URLs correctly
Base automatically changed from
constantinius/fix/redact-message-parts-type-blob
to
master
January 13, 2026 09:56
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Litellm
Other
Documentation 📚
Internal Changes 🔧Release
Other
🤖 This preview updates automatically when you update the PR. |
| "modality": "image", | ||
| "mime_type": mime_type, | ||
| "content": content, | ||
| } |
There was a problem hiding this comment.
Non-base64 data URIs incorrectly converted to blob type
Medium Severity
The _convert_message_parts function converts ALL data URIs starting with data: to blob type, but the test test_convert_message_parts_data_url_without_base64 expects non-base64 data URIs (like data:image/png,rawdata) to be converted to uri type instead. The parse_data_uri function successfully parses any data URI with a comma, so the exception-based fallback to uri type never triggers for valid non-base64 data URIs. The code needs to check for ;base64 in the data URI header before treating it as a blob.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Closes https://linear.app/getsentry/issue/TET-1635/redact-images-litellm