Skip to content

Conversation

@JPeer264
Copy link
Member

There were 3 different PRs opened for a remix-run update: #18750 #18747 #18746

Each failed because they needed the other packages to be there. Not all @remix-run/* packages follow the same version update, just some. But it is still better to update all together nontheless

@JPeer264 JPeer264 self-assigned this Jan 19, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

- '@opentelemetry/*'
remix:
patterns:
- '@remix-run/*'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remix group defined but packages not in allow list

Medium Severity

The remix group is added with pattern @remix-run/*, but @remix-run/* is not included in the allow list. When an allow list is specified, dependabot only updates dependencies matching those patterns. The group definition is effectively unused because those packages won't receive version updates. To achieve the PR's stated goal of updating remix-run packages together, @remix-run/* needs to be added to the allow list as well.

Additional Locations (1)

Fix in Cursor Fix in Web

Comment on lines +26 to +28
remix:
patterns:
- '@remix-run/*'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The new remix dependency group will not receive updates because the @remix-run/* pattern is missing from the allow list in the Dependabot configuration.
Severity: CRITICAL

Suggested Fix

Add the @remix-run/* pattern to the allow list in the .github/dependabot.yml file to enable Dependabot to create pull requests for these dependencies.

allow:
  - dependency-name: '@sentry/*'
  - dependency-name: '@playwright/test'
  - dependency-name: '@opentelemetry/*'
  - dependency-name: '@remix-run/*' # Add this line
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/dependabot.yml#L26-L28

Potential issue: The `dependabot.yml` configuration is being updated to group
`@remix-run/*` dependencies. However, the configuration includes a restrictive `allow`
list that dictates which dependencies Dependabot can update. The pattern `@remix-run/*`
has not been added to this `allow` list. As a result, Dependabot will ignore all
`@remix-run/*` packages and will not create any pull requests for their updates. This
defeats the purpose of the change and prevents the project from receiving security and
version updates for these dependencies.

Did we get this right? 👍 / 👎 to inform future reviews.

@github-actions
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,084 - 8,835 +3%
GET With Sentry 1,822 20% 1,753 +4%
GET With Sentry (error only) 6,146 68% 5,998 +2%
POST Baseline 1,219 - 1,143 +7%
POST With Sentry 605 50% 556 +9%
POST With Sentry (error only) 1,066 87% 1,049 +2%
MYSQL Baseline 3,413 - 3,329 +3%
MYSQL With Sentry 513 15% 472 +9%
MYSQL With Sentry (error only) 2,759 81% 2,691 +3%

View base workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants