-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore(dependabot): Update remix-run all together #18885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| - '@opentelemetry/*' | ||
| remix: | ||
| patterns: | ||
| - '@remix-run/*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remix group defined but packages not in allow list
Medium Severity
The remix group is added with pattern @remix-run/*, but @remix-run/* is not included in the allow list. When an allow list is specified, dependabot only updates dependencies matching those patterns. The group definition is effectively unused because those packages won't receive version updates. To achieve the PR's stated goal of updating remix-run packages together, @remix-run/* needs to be added to the allow list as well.
Additional Locations (1)
| remix: | ||
| patterns: | ||
| - '@remix-run/*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The new remix dependency group will not receive updates because the @remix-run/* pattern is missing from the allow list in the Dependabot configuration.
Severity: CRITICAL
Suggested Fix
Add the @remix-run/* pattern to the allow list in the .github/dependabot.yml file to enable Dependabot to create pull requests for these dependencies.
allow:
- dependency-name: '@sentry/*'
- dependency-name: '@playwright/test'
- dependency-name: '@opentelemetry/*'
- dependency-name: '@remix-run/*' # Add this linePrompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/dependabot.yml#L26-L28
Potential issue: The `dependabot.yml` configuration is being updated to group
`@remix-run/*` dependencies. However, the configuration includes a restrictive `allow`
list that dictates which dependencies Dependabot can update. The pattern `@remix-run/*`
has not been added to this `allow` list. As a result, Dependabot will ignore all
`@remix-run/*` packages and will not create any pull requests for their updates. This
defeats the purpose of the change and prevents the project from receiving security and
version updates for these dependencies.
Did we get this right? 👍 / 👎 to inform future reviews.
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
There were 3 different PRs opened for a remix-run update: #18750 #18747 #18746
Each failed because they needed the other packages to be there. Not all
@remix-run/*packages follow the same version update, just some. But it is still better to update all together nontheless