-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(deps): Bump OpenTelemetry dependencies #18878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
cad2fac
0762132
e28b69b
b46b3df
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,6 +43,9 @@ const baseConfig = makeBaseNPMConfig({ | |
| plugins.makeJsonPlugin(), // Needed because `require-in-the-middle` imports json via require | ||
| replace({ | ||
| preventAssignment: true, | ||
| // Use negative lookahead/lookbehind instead of word boundaries so `process.argv0` is also replaced in | ||
| // `process.argv0.length` (where `.` follows). Default `\b` delimiters don't match before `.`. | ||
| delimiters: ['(?<![\\w$])', '(?![\\w$])'], | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. l: Why has this been added?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was added because with 2.4.0, the way they are using |
||
| values: { | ||
| 'process.argv0': JSON.stringify(''), // needed because otel relies on process.argv0 for the default service name, but that api is not available in the edge runtime. | ||
| }, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to keep this all in the changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry didn't see this comment. I aligned this with how dependabot PRs end up in the changelog, one entry per dep with clear statement of what was bumped from what.
We could also just leave it in the PR description but I preferred to be explicit. Happy to change in the future tho.