feat(distribution): Add install_groups support #5062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
|
runningcode
commented
Jan 27, 2026
runningcode
force-pushed
the
no/install-groups-support
branch
from
3bb32d4 to
9f48234
Compare
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dba088c | 321.78 ms | 364.59 ms | 42.82 ms |
| 3699cd5 | 423.60 ms | 495.52 ms | 71.92 ms |
| fcec2f2 | 311.35 ms | 384.94 ms | 73.59 ms |
| 1edbdfa | 364.77 ms | 450.29 ms | 85.52 ms |
| dba088c | 333.98 ms | 381.16 ms | 47.18 ms |
| fc5ccaf | 270.49 ms | 363.90 ms | 93.41 ms |
| 539ca63 | 313.51 ms | 355.43 ms | 41.92 ms |
| ee747ae | 386.94 ms | 431.43 ms | 44.49 ms |
| b77456b | 393.26 ms | 441.10 ms | 47.84 ms |
| 694d587 | 305.45 ms | 378.38 ms | 72.94 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dba088c | 1.58 MiB | 2.13 MiB | 558.99 KiB |
| 3699cd5 | 1.58 MiB | 2.10 MiB | 533.45 KiB |
| fcec2f2 | 1.58 MiB | 2.12 MiB | 551.51 KiB |
| 1edbdfa | 1.58 MiB | 2.20 MiB | 635.34 KiB |
| dba088c | 1.58 MiB | 2.13 MiB | 558.99 KiB |
| fc5ccaf | 1.58 MiB | 2.13 MiB | 557.54 KiB |
| 539ca63 | 1.58 MiB | 2.12 MiB | 551.41 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| b77456b | 1.58 MiB | 2.12 MiB | 548.11 KiB |
| 694d587 | 1.58 MiB | 2.19 MiB | 620.06 KiB |
runningcode
commented
Jan 27, 2026
| final @NotNull String downloadUrl, | ||
| final @NotNull String appName, | ||
| final @Nullable String createdDate) { | ||
| final @Nullable String createdDate, |
Contributor
Author
There was a problem hiding this comment.
This is a breaking change to the constructor. I don't think the constructor is used directly by consumers so it is fine.
Add installGroupsOverride parameter to UpdateCheckParams and installGroups property to UpdateInfo for the Build Distribution SDK, matching the iOS implementation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
runningcode
force-pushed
the
no/install-groups-support
branch
from
9f48234 to
c6b0c3c
Compare
runningcode
requested review from
adinauer,
lcian,
markushi and
romtsn
as code owners
romtsn
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
installGroupsOverrideparameter toUpdateCheckParamsfor specifying install groups when checking for updatesinstallGroupsproperty toUpdateInfoto receive install groups from the API responseinstall_groupsfrom the distribution API responseThis matches the iOS implementation: getsentry/sentry-cocoa#7278
🤖 Generated with Claude Code