Skip to content

Improve detection of s3fs and skip tests requiring it #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avalentino wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve detection of s3fs and skip tests requiring it #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions upath/tests/implementations/test_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ def test_pathlib_consistent_join():


def test_copy__object_key_collides_with_dir_prefix(s3_server, tmp_path):
pytest.importorskip("s3fs")
anon, s3so = s3_server

s3 = fsspec.filesystem("s3", anon=anon, **{**s3so, "use_listings_cache": False})
Expand Down
4 changes: 4 additions & 0 deletions upath/tests/test_relative.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ def test_protocol_storage_options_fs_preserved(protocol, storage_options, path,

assert rel.protocol == protocol
assert dict(**rel.storage_options) == storage_options
try:
rel.fs
except ImportError:
pytest.skip(reason=f"{protocol} not available")
assert isinstance(rel.fs, type(p.fs))


Expand Down