Fixed vmdk thin opening when parentFileNameHint was set to full path #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schamper
requested changes
Feb 10, 2026
Member
Schamper
left a comment
Schamper
left a comment
There was a problem hiding this comment.
Maybe nice to swap it around, since I think for our purposes we generally have the first case scenario.
| filename_hint = filename_hint.replace("\\", "/") | ||
| hint_path, _, filename = filename_hint.rpartition("/") | ||
| filepath = path.joinpath(filename) | ||
| filepath = path.joinpath(filename_hint) |
Member
There was a problem hiding this comment.
Suggested change
| filepath = path.joinpath(filename_hint) | |
| filepath = path.joinpath(filename) |
| if not filepath.exists(): | ||
| _, _, hint_path_name = hint_path.rpartition("/") | ||
| filepath = path.parent.joinpath(hint_path_name).joinpath(filename) | ||
| filepath = path.joinpath(filename) |
Member
There was a problem hiding this comment.
Suggested change
| filepath = path.joinpath(filename) | |
| filepath = path.joinpath(filename_hint) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 78.64% 79.04% +0.40%
==========================================
Files 26 26
Lines 2332 2334 +2
==========================================
+ Hits 1834 1845 +11
+ Misses 498 489 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed VMDK thin opening when parentFileNameHint was set to full path
When attempting to mount a VMDK file that was created using thin
provisioning, it would fail with a file not found error on the parent VMDK
file, due to it attempting to find it in the same directory. However, the
parentFileNameHint was set to the full path of the parent VMDK file, but
ignored by dissect. This pull requests attempts to load the VMDK parent
file using the parentFileNameHint first, before continuing with the
existing loading method.
Fixes #77