Added support for Auditing Issues/Vulnerabilities in SSC#919
Open
jmadhur87 wants to merge 7 commits intofortify:dev/v3.xfrom
Open
Added support for Auditing Issues/Vulnerabilities in SSC#919jmadhur87 wants to merge 7 commits intofortify:dev/v3.xfrom
jmadhur87 wants to merge 7 commits intofortify:dev/v3.xfrom
Conversation
…87/fcli into mjain6/SSCAuditingUpdate
SangameshV
reviewed
Feb 18, 2026
Contributor
SangameshV
left a comment
There was a problem hiding this comment.
Hi @jmadhur87 , pleae have a look at the comments and share your inputs.
fcli-core/fcli-ssc/src/main/java/com/fortify/cli/ssc/issue/cli/cmd/SSCIssueUpdateCommand.java
Show resolved
Hide resolved
fcli-core/fcli-ssc/src/main/java/com/fortify/cli/ssc/issue/cli/cmd/SSCIssueUpdateCommand.java
Show resolved
Hide resolved
fcli-core/fcli-ssc/src/main/java/com/fortify/cli/ssc/issue/cli/cmd/SSCIssueUpdateCommand.java
Show resolved
Hide resolved
fcli-core/fcli-ssc/src/main/java/com/fortify/cli/ssc/issue/cli/cmd/SSCIssueUpdateCommand.java
Outdated
Show resolved
Hide resolved
fcli-core/fcli-ssc/src/main/java/com/fortify/cli/ssc/issue/cli/cmd/SSCIssueUpdateCommand.java
Outdated
Show resolved
Hide resolved
rsenden
reviewed
Feb 18, 2026
| @Option(names = {"--assign-user"}) | ||
| private String assignUser; | ||
|
|
||
| private UnirestInstance unirestInstance; |
Contributor
There was a problem hiding this comment.
As discussed before, command classes shouldn't have any instance fields, other than those annotation with picocli annotations like @Option or @Mixin. Please remove the unirestInstance field, and just pass to the methods that need it. If necessary, you can create a separate class that takes UnirestInstance as a constructor parameter, and have that class implement most of the logic, i.e.., in the getJsonNode method you could do something like return new MyHelper(unirest).performWork();. But only do this if such an extra class makes things significantly simpler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Added support for Auditing Issues/Vulnerabilities in SSC using FCLI
Introduce new SSC issue update CLI command to support updating SSC issues from the CLI.
Supports options: --issue-ids (required), --custom-tags / -t (TAG=VALUE, comma-separated), --suppress (true|false), --comment (text), and --assign-user (username or id).