Conversation
Provide a `lint` command. Making `eslint` a direct dependency here and providing a command to access it allows this package to serve as a conduit through which other packages can access it without having to maintain it as a direct dependency. Refs STCLI-207
|
Member
Author
|
@JohnC-80 , do you think this impl is worthwhile, or should it be a whole lot dumber, e.g. |
Member
Author
|
Converting this to draft to take it off the table. The idea is sound but the impl lacks. I think the "right" impl is the "whole lot dumber" one: sth like spawn('lint'). |
Member
Author
|
This implementation does WAY too much work. Move the config and dependencies from https://github.com/folio-org/eslint-config-stripes into this repo and then implement this by just calling lint the same we call babel in #368. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Provide a
lintcommand. Makingeslinta direct dependency here and providing a command to access it allows this package to serve as a conduit through which other packages can access it without having to maintain it as a direct dependency.Refs STCLI-207