Merged
Conversation
Contributor
nfebe
commented
Jan 31, 2026
nfebe
commented
- Add DomainsManager component for multi-domain table view
- Add DomainFormModal for creating/editing domains
- Add domain CRUD API methods to deploymentsApi
- Update DeploymentDetailView with unified handleDeleteDomain
- Add hasMultipleDomains and singleDomainId computed properties
- Add tests for domain-related computed properties
Code Review SummaryThis pull request introduces a comprehensive multi-domain management feature for deployments, significantly enhancing the flexibility of domain configurations. It involved creating two new components, 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
Deploying flatrun-ui with
|
| Latest commit: |
f01a901
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a6ed65e4.flatrun-ui.pages.dev |
| Branch Preview URL: | https://feat-multi-domain-support.flatrun-ui.pages.dev |
- Add DomainsManager component for multi-domain table view - Add DomainFormModal for creating/editing domains - Add domain CRUD API methods to deploymentsApi - Update DeploymentDetailView with unified handleDeleteDomain - Add hasMultipleDomains and singleDomainId computed properties - Add tests for domain-related computed properties Signed-off-by: nfebe <fenn25.fn@gmail.com>
- Add DatabaseConfig interface to types - Add advanced options in Compose Mode for multi-domain/database - Add dynamic wizard steps based on advanced options selection - Add Domains step for routing domains to different services - Add multi-database UI in Database step with add/remove support - Display database configs in DeploymentDetailView - Update handleCreate to send domains and databases arrays - Add comprehensive type tests for new interfaces Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
feat/multi-domain-support
branch
from
fe6199b to
f01a901
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.