Merged
Conversation
Contributor
nfebe
commented
Jan 14, 2026
nfebe
commented
- Add DNS section to sidebar navigation
- Add DnsZonesView for PowerDNS zone/record management
- Add DnsExternalView for external DNS providers
- Add API clients for PowerDNS and external DNS providers
- Add DNS store for state management
- Add routes for /dns/zones and /dns/external
Code Review Summary✨ This pull request introduces comprehensive DNS management capabilities, split into two new views: one for external DNS providers and another for a self-hosted PowerDNS server. It includes new API service definitions, a Pinia store for state management, and updates to the dashboard layout and router. The implementation is robust, adheres to existing project patterns, and covers a wide range of functionalities, including provider integration, zone listing, and record CRUD operations. 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
- Add DNS section to sidebar navigation - Add DnsZonesView for PowerDNS zone/record management - Add DnsExternalView for external DNS providers - Add API clients for PowerDNS and external DNS providers - Add DNS store for state management - Add routes for /dns/zones and /dns/external Signed-off-by: nfebe <fenn25.fn@gmail.com>
Deploying flatrun-ui with
|
| Latest commit: |
bb6d52f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://db226c23.flatrun-ui.pages.dev |
| Branch Preview URL: | https://feat-dns-ui.flatrun-ui.pages.dev |
- Extract lines of duplicated CSS into shared dns-shared.css - Add clarity to "Auto" TTL option in external DNS (explains provider default) - Add TTL validation hints and min/max bounds for PowerDNS - Both views now import shared styles, reducing duplication significantly Signed-off-by: nfebe <fenn25.fn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.