fix(nginx): Increase server_names_hash_bucket_size to 128#73
Merged
Conversation
Code Review Summary✨ This pull request primarily standardizes the 🚀 Key Improvements
💡 Minor Suggestions
🚨 Critical Issues
|
Long domain names (e.g., auto-generated subdomains) can exceed the default bucket size of 64, causing nginx config test to fail with: [emerg] could not build server_names_hash, you should increase server_names_hash_bucket_size: 64 Increasing to 128 accommodates longer domain names. Signed-off-by: nfebe <fenn25.fn@gmail.com>
176ed6a to
91152a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long domain names (e.g., auto-generated subdomains) can exceed the default bucket size of 64, causing nginx config test to fail with:
[emerg] could not build server_names_hash, you should increase
server_names_hash_bucket_size: 64
Increasing to 128 accommodates longer domain names.