feat: Refactor shader uniform binding to support shader arrays [flame_3d] by luanpotter · Pull Request #3282 · flame-engine/flame

luanpotter · 2024-08-25T19:54:30Z

Description

Refactor shader uniform binding to support shader arrays.

This also decouples the whole shader and uniform byte handling code (that we should definitely test) from the flutter_gpu primitives that are impossible to mock (base native classes).

This adds tests that ensure the arrays are bound as they should - however the underlying flutter_gpu code does not seem to work. See this PR for a test of using this to support an arbitrary number of lights.

Either way, we can merge this as is as this refactors the underlying structure to support arrays when ready, and make it more testable as well.

Checklist

I have followed the Contributor Guide when preparing my PR.
I have updated/added tests for ALL new/updated/fixed functionality.
I have updated/added relevant documentation in docs and added dartdoc comments with ///.
I have updated/added relevant examples in examples or docs.

Breaking Change?

Yes, this PR is a breaking change.
No, this PR is not a breaking change.

luanpotter · 2024-09-12T21:23:33Z

examples/lib/stories/system/resize_example.dart

    super.onGameResize(size);

-    this.size = size * .4;
+    this.size = size * 0.4;


unrelated DCM

luanpotter · 2024-09-12T21:23:51Z

packages/flame_3d/lib/src/resources/material/material.dart

-        _vertexShader.resource,
-        _fragmentShader.resource,
+        _vertexShader.compile().resource,
+        _fragmentShader.compile().resource,


I'm open to any other cleaner ways to make this testable

spydon · 2024-09-12T21:47:57Z

Have you reported that it doesn't work in flutter_gpu?

luanpotter · 2024-09-13T18:47:04Z

I've been talking with @bdero about it; he suggested using DeviceBuffer instead of HostBuffer but I haven't had time to try it yet.

Either way, I believe the Flame-facing API should be independent of this (though I def want to completely overhaul it to be type safe, the current one is reliant on strings).

Support skeletal animation basics. Sadly we cannot support arrays yet - see [this PR](#3282).

spydon

Lgtm!

Support skeletal animation basics. Sadly we cannot support arrays yet - see [this PR](#3282).

…_3d] (#3282) Refactor shader uniform binding to support shader arrays. This also decouples the whole shader and uniform byte handling code (that we should definitely test) from the flutter_gpu primitives that are impossible to mock (base native classes). This adds tests that ensure the arrays are bound as they should - however the underlying flutter_gpu code does not seem to work. See [this PR](#3284) for a test of using this to support an arbitrary number of lights. Either way, we can merge this as is as this refactors the underlying structure to support arrays when ready, and make it more testable as well.

Support skeletal animation basics. Sadly we cannot support arrays yet - see [this PR](#3282).

…_3d] (#3282) Refactor shader uniform binding to support shader arrays. This also decouples the whole shader and uniform byte handling code (that we should definitely test) from the flutter_gpu primitives that are impossible to mock (base native classes). This adds tests that ensure the arrays are bound as they should - however the underlying flutter_gpu code does not seem to work. See [this PR](#3284) for a test of using this to support an arbitrary number of lights. Either way, we can merge this as is as this refactors the underlying structure to support arrays when ready, and make it more testable as well.

Support skeletal animation basics. Sadly we cannot support arrays yet - see [this PR](#3282).

…_3d] (#3282) Refactor shader uniform binding to support shader arrays. This also decouples the whole shader and uniform byte handling code (that we should definitely test) from the flutter_gpu primitives that are impossible to mock (base native classes). This adds tests that ensure the arrays are bound as they should - however the underlying flutter_gpu code does not seem to work. See [this PR](#3284) for a test of using this to support an arbitrary number of lights. Either way, we can merge this as is as this refactors the underlying structure to support arrays when ready, and make it more testable as well.

Support skeletal animation basics. Sadly we cannot support arrays yet - see [this PR](flame-engine#3282).

…_3d] (flame-engine#3282) Refactor shader uniform binding to support shader arrays. This also decouples the whole shader and uniform byte handling code (that we should definitely test) from the flutter_gpu primitives that are impossible to mock (base native classes). This adds tests that ensure the arrays are bound as they should - however the underlying flutter_gpu code does not seem to work. See [this PR](flame-engine#3284) for a test of using this to support an arbitrary number of lights. Either way, we can merge this as is as this refactors the underlying structure to support arrays when ready, and make it more testable as well.

luanpotter force-pushed the flame_3d branch from 9694579 to 07594dd Compare August 25, 2024 20:17

luanpotter force-pushed the luan.shader-arrays branch from 03f390e to 78511f2 Compare August 25, 2024 22:59

luanpotter mentioned this pull request Aug 29, 2024

feat: Support skeletal animation basics [flame_3d] #3291

Merged

6 tasks

luanpotter changed the title ~~feat: Refactor shader uniform binding to support shader arrays~~ feat: Refactor shader uniform binding to support shader arrays [flame_3d] Sep 11, 2024

luanpotter force-pushed the flame_3d branch from df7a0f1 to 75e64a7 Compare September 11, 2024 21:16

luanpotter force-pushed the luan.shader-arrays branch from aebbdb2 to 8158d30 Compare September 12, 2024 20:53

luanpotter marked this pull request as ready for review September 12, 2024 21:01

luanpotter requested review from spydon and wolfenrain September 12, 2024 21:02

luanpotter commented Sep 12, 2024

View reviewed changes

luanpotter added a commit that referenced this pull request Sep 13, 2024

feat: Support skeletal animation basics [flame_3d] (#3291)

12927e4

Support skeletal animation basics. Sadly we cannot support arrays yet - see [this PR](#3282).

luanpotter added 2 commits September 13, 2024 15:35

feat: Refactor shader uniform binding to support shader arrays

3f8e4d6

Fix DCM

9132ee8

luanpotter force-pushed the luan.shader-arrays branch from 8158d30 to 9132ee8 Compare September 13, 2024 19:35

luanpotter mentioned this pull request Sep 16, 2024

[Flame 3D] Create more distinct types of light source #3294

Open

1 task

spydon approved these changes Sep 20, 2024

View reviewed changes

luanpotter merged commit 0c0e8f2 into flame_3d Sep 21, 2024

luanpotter deleted the luan.shader-arrays branch September 21, 2024 00:18

luanpotter added a commit that referenced this pull request Oct 15, 2024

feat: Support skeletal animation basics [flame_3d] (#3291)

5b2a7b4

Support skeletal animation basics. Sadly we cannot support arrays yet - see [this PR](#3282).

luanpotter added a commit that referenced this pull request Dec 11, 2024

feat: Support skeletal animation basics [flame_3d] (#3291)

74be3dc

Support skeletal animation basics. Sadly we cannot support arrays yet - see [this PR](#3282).

luanpotter added a commit that referenced this pull request Dec 11, 2024

feat: Support skeletal animation basics [flame_3d] (#3291)

9c0d150

Support skeletal animation basics. Sadly we cannot support arrays yet - see [this PR](#3282).

nickf2k pushed a commit to nickf2k/flame that referenced this pull request Nov 16, 2025

feat: Support skeletal animation basics [flame_3d] (flame-engine#3291)

02ac014

Support skeletal animation basics. Sadly we cannot support arrays yet - see [this PR](flame-engine#3282).

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Refactor shader uniform binding to support shader arrays [flame_3d]#3282

feat: Refactor shader uniform binding to support shader arrays [flame_3d]#3282
luanpotter merged 2 commits intoflame_3dfrom
luan.shader-arrays

luanpotter commented Aug 25, 2024 •

edited

Loading

Uh oh!

luanpotter Sep 12, 2024

Uh oh!

luanpotter Sep 12, 2024 •

edited

Loading

Uh oh!

spydon commented Sep 12, 2024

Uh oh!

luanpotter commented Sep 13, 2024

Uh oh!

spydon left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

luanpotter commented Aug 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Breaking Change?

Uh oh!

luanpotter Sep 12, 2024

Choose a reason for hiding this comment

Uh oh!

luanpotter Sep 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spydon commented Sep 12, 2024

Uh oh!

luanpotter commented Sep 13, 2024

Uh oh!

spydon left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

luanpotter commented Aug 25, 2024 •

edited

Loading

luanpotter Sep 12, 2024 •

edited

Loading