test-import-headers: honor CPPFLAGS, CFLAGS, CXXFLAGS, and LDFLAGS #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisar
approved these changes
Jan 14, 2026
Collaborator
ppisar
left a comment
ppisar
left a comment
There was a problem hiding this comment.
It's a good idea.
The script is pretty trivial: It does not respect compiler names used by the meson build script, it should only compile without linking, it should be merged into meson script to support parallelization etc. I even did not knew it's there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, thanks a lot for writing and maintaining libmodulemd!
What do you think about this trivial change that makes the
test-import-headers.shtool honor the compiler and linker flags? In some build environments this may be important, e.g. for build hardening or platform-specific flags, etc.Thanks again, and keep up the great work!
G'luck,
Peter