Do not use abandoned arms as pending points; add completed trials without data as pending#4955
Closed
sdaulton wants to merge 1 commit intofacebook:mainfrom
Closed
Do not use abandoned arms as pending points; add completed trials without data as pending#4955sdaulton wants to merge 1 commit intofacebook:mainfrom
sdaulton wants to merge 1 commit intofacebook:mainfrom
Conversation
…hout data as pending Summary: Two changes to how pending observation features are computed: 1. **Do not use individually abandoned arms as pending points.** Previously, arms that were individually abandoned within a BatchTrial (via `mark_arm_abandoned`) were explicitly added as pending observation features. This is removed — individually abandoned arms should not occupy the pending point space. Note: arms belonging to fully *abandoned trials* are still treated as pending, since the entire trial was abandoned and the model should avoid re-suggesting those configurations. 2. **Treat completed trials without data as pending.** Previously, completed trials were never considered pending, even if they had no data for some metrics. Now, `get_pending_observation_features` checks completed trials for missing metric data and marks those arms as pending for the missing metrics, consistent with how deployed (STAGED/RUNNING) trials are handled. Differential Revision: D94531161
|
This pull request has been merged in 8215f32. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4955 +/- ##
==========================================
- Coverage 96.83% 96.83% -0.01%
==========================================
Files 596 596
Lines 63108 63103 -5
==========================================
- Hits 61109 61103 -6
- Misses 1999 2000 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Two changes to how pending observation features are computed:
Do not use individually abandoned arms as pending points. Previously,
arms that were individually abandoned within a BatchTrial (via
mark_arm_abandoned) were explicitly added as pending observation features.This is removed — individually abandoned arms should not occupy the pending
point space. Note: arms belonging to fully abandoned trials are still
treated as pending, since the entire trial was abandoned and the model should
avoid re-suggesting those configurations.
Treat completed trials without data as pending. Previously, completed
trials were never considered pending, even if they had no data for some
metrics. Now,
get_pending_observation_featureschecks completed trials formissing metric data and marks those arms as pending for the missing metrics,
consistent with how deployed (STAGED/RUNNING) trials are handled.
Differential Revision: D94531161