Skip to content

Conversation

@everoddandeven
Copy link
Owner

This PR includes:

  • Wallet rpc logic fixes
  • Enable more wallet rpc tests
  • Add mining wallet
  • Remove close wallet logic causing UB
  • Add scripts for docker test environment setup/cleanup
  • Set mining wallet address in node_1 docker container

* Wallet rpc logic fixes
* Enable more wallet rpc tests
* Add mining wallet
* Remove close wallet logic causing UB
* Add scripts for docker test environment setup/cleanup
* Set mining wallet address in node_1 docker container
@codacy-production
Copy link

codacy-production bot commented Jan 21, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+2.61% (target: -1.00%) 89.85%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f9816f3) 11118 5983 53.81%
Head commit (3eb2def) 11033 (-85) 6225 (+242) 56.42% (+2.61%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#36) 266 239 89.85%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@everoddandeven everoddandeven merged commit a136872 into main Jan 21, 2026
4 checks passed
@everoddandeven everoddandeven deleted the mining-wallet branch January 21, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants