Skip to content

Add Types to align with fidesplus#7331

Merged
gilluminate merged 1 commit intomainfrom
gill/ENG-2518/add-iabtcf-disclosed-vendors
Feb 6, 2026
Merged

Add Types to align with fidesplus#7331
gilluminate merged 1 commit intomainfrom
gill/ENG-2518/add-iabtcf-disclosed-vendors

Conversation

@gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Feb 6, 2026

Ticket ENG-2518

Description Of Changes

Adding Types similar to the others. This coincides with https://github.com/ethyca/fidesplus/pull/3052

Code Changes

  • Add Type support for IABTCF_DisclosedVendors mobile data

@vercel
Copy link
Contributor

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 6, 2026 4:51pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 6, 2026 4:51pm

Request Review

@gilluminate gilluminate requested a review from JadeCara February 6, 2026 22:17
@gilluminate gilluminate marked this pull request as ready for review February 6, 2026 22:17
@gilluminate gilluminate requested a review from a team as a code owner February 6, 2026 22:17
@gilluminate gilluminate requested review from jpople and removed request for a team and jpople February 6, 2026 22:17
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 6, 2026

Greptile Overview

Greptile Summary

This PR adds support for the IABTCF_DisclosedVendors field to the TCMobileData type across three frontend clients (admin-ui, fides-js, and privacy-center). The field follows the IAB TCF v2 specification for mobile consent management and tracks which vendors have been disclosed in the CMP interface.

  • The implementation is consistent across all three locations, maintaining each file's existing type patterns
  • Proper JSDoc documentation explains the binary string format and indexing convention
  • The field is appropriately marked as optional, matching the pattern of similar TCF fields
  • The change aligns with the fidesplus PR mentioned in the description for cross-repository type consistency

Confidence Score: 5/5

  • This PR is safe to merge with no risks
  • Simple additive change adding a single optional field across three type definition files. The implementation is consistent with existing patterns in each file, properly documented, and follows the IAB TCF specification. No breaking changes or logic modifications.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/types/api/models/TCMobileData.ts Added IABTCF_DisclosedVendors optional field with proper documentation following existing type patterns
clients/fides-js/src/lib/consent-types.ts Added IABTCF_DisclosedVendors optional field consistent with the file's type pattern
clients/privacy-center/types/api/models/TCMobileData.ts Added IABTCF_DisclosedVendors optional field matching the structure of other TCMobileData fields

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@JadeCara JadeCara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@gilluminate gilluminate added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit b952928 Feb 6, 2026
45 of 46 checks passed
@gilluminate gilluminate deleted the gill/ENG-2518/add-iabtcf-disclosed-vendors branch February 6, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants