Allow selection of which metrics to submit from Librato metrics reporter#9
Open
ryanlower wants to merge 1 commit intoeric:masterfrom
Open
Allow selection of which metrics to submit from Librato metrics reporter#9ryanlower wants to merge 1 commit intoeric:masterfrom
ryanlower wants to merge 1 commit intoeric:masterfrom
Conversation
Owner
|
This is great. It may be a couple days before I get a chance to merge and release this — I'm traveling in Japan at the moment... but this looks useful. Thanks for the pull request. |
Owner
There was a problem hiding this comment.
Defaulting these to an empty array is going to cause the if's later on to always evaluate to true.
I think this may be worth a test case to not break things.
|
This one is going to really come in handy. Thanks guys! |
Owner
There was a problem hiding this comment.
With the defaulting above, this is going to need to be if @only && !@only.empty? — same with the @except one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can specific
:onlyor:exceptwhen initializing the reporter, e.g.