Closed
Conversation
added 4 commits
June 26, 2013 22:27
* Add reportable_metrics class method to all metric types * Add reportable_snapshot_metrics class method to all metric types * Allow desired percentiles to be passed in for snapshot metrics
…ethods. * Add VALID_PERCENTILES constant to Snapshot class * Reference VALID_PERCENTILES to create a convenience method for checking validity * Add method for taking a list of percentiles and turning them into valid methods to be called on Snapshot objects
* Update reporters to use the reportable_metrics and reportable_snapshot_metrics class methods
Author
|
Hmm, apparently 1.8.7 doesn't like assert_not_empty. Additionally, I started looking through some other pull requests and see that there are other pull requests similar to mine. Have you started pulling out reporters yet? Is a better approach to pull out the LibratoMetrics reporter? |
Owner
|
I made some progress on #37 over the weekend, but still have some unresolved issues on how I'm going to roll it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I set out to add an option to the Librato reporter so that custom/additional percentiles could be reported. I ended up doing some refactoring for the lists of metrics supported for each metric type in various Reporters to reduce some duplication.
I added some tests I thought were helpful and added documentation where it made sense. I'd love some feedback on this, so let me know!
Thanks!