Open
Conversation
…ified in a list. Fixed PEP8 errors where possible.
Collaborator
|
Hi, this looks great. I'll take a closer look next week and get it merged (and cut a release). Sorry for the delay. |
|
Any updates? |
Collaborator
|
Unfortunately I don't have much time to put to engarde these days.
…On Fri, May 25, 2018 at 9:07 AM, Luciano Viola ***@***.***> wrote:
Any updates?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIqZoIiQdTOWFUj2qFPhJrpQHdbU8ks5t2BAEgaJpZM4NpIwW>
.
|
Contributor
|
@TomAugspurger Lemme know if you need a hand with engarde. I've used it in a side project, will be bringing it into work projects over the next few months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey man! Thanks for the amazing repo! It's an elegant pythonesque way for validating data in a Pandas DataFrame.
has_columnsis another check that is performed quite often in my workflow, so I thought of adding this to a common place, aka your repo. In this PR, I have added a decoratorhas_columns, for checking if a DataFrame has all the columns specified in a list. Fixed PEP8 errors where possible and added Pycharm xml files to .gitignore.