Basic chat formatting. (Markdown bold and italic)#30
Open
gkbrk wants to merge 2 commits intoeleweek:masterfrom
gkbrk:chat_formatting
Open
Basic chat formatting. (Markdown bold and italic)#30gkbrk wants to merge 2 commits intoeleweek:masterfrom gkbrk:chat_formatting
gkbrk wants to merge 2 commits intoeleweek:masterfrom
gkbrk:chat_formatting
Conversation
Owner
|
Hm, that's quite non-standard, e.g. bold could be done using two underscores. I think it'd be better to use some lib, e.g. this one: https://github.com/chjj/marked |
Contributor
Author
|
I made it so it matches Since we store the markdown in the database before converting to html, we can always switch to the library if we want more markdown features. Here's the library code in case we need the relevant lines for bold and italic text. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on Firefox.