Make install_packages resilient to 500 Server Error

[gsoldevila]

Addresses eventual CI failures such as this one.

INFO:docker build:#19 [node_deps 4/7] RUN install_packages yarn=1.22.19-1
INFO:docker build:#19 7.734 W: Failed to fetch https://deb.nodesource.com/node_12.x/dists/buster/InRelease  500  Internal Server Error [IP: 172.66.150.169 443]
INFO:docker build:#19 7.734 W: Failed to fetch https://dl.yarnpkg.com/debian/dists/stable/InRelease  500  Internal Server Error [IP: 104.16.169.120 443]
INFO:docker build:#19 7.734 W: Some index files failed to download. They have been ignored, or old ones used instead.

The official install_packages script fails if the package repository fails with 500 Server Error when trying to fetch the package lists (which happens from time to time).
This PR adds a wrapper script with a retry mechanism, so that we don't give up that quickly.

[github-actions]

A documentation preview will be available soon.

• 🔨 Buildkite builds
• 📚 HTML diff
• 📙 Preview page

Request a new doc build by commenting

• Rebuild this PR: run docs-build
• Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

[gsoldevila]

@nik9000 I don't fully understand your comment above, but I wonder if the wrapper script that I'm introducing can help in any way.

[Copilot]

Pull Request Overview

This PR addresses intermittent CI failures caused by 500 Server Errors from package repositories during install_packages operations. It introduces a retry mechanism to make package installation more resilient to transient network failures.

Key Changes:

• Added a new install_packages.sh wrapper script with retry logic (up to 5 attempts with 10-second delays)
• Updated all install_packages calls in the Dockerfile to use the new install_packages.sh wrapper

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
install_packages.sh	New wrapper script that adds retry logic around the existing install_packages command to handle transient 500 errors
Dockerfile	Copies the wrapper script and updates all package installation commands to use install_packages.sh instead of install_packages

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The comment says "exit the function" but this is a script, not a function. The comment should say "exit the script" for clarity.

Suggested change

	exit 0 # Success, exit the function
	exit 0 # Success, exit the script

[Copilot]

Using $? in a condition is fragile. The exit status should be captured immediately after the command. Consider rewriting as:

if install_packages "$@"; then
    echo "Packages installed successfully."
    exit 0
else
    RETRY_COUNT=$((RETRY_COUNT + 1))
    # ... rest of error handling
fi

This ensures the exit status is evaluated correctly without risk of being overwritten by intervening commands.

[Copilot]

The variable $@ should be quoted as "$@" to properly handle arguments containing spaces or special characters. Without quotes, arguments with spaces will be split into multiple arguments.

Suggested change

	echo "Attempt $((RETRY_COUNT + 1)) of $MAX_ATTEMPTS: Running install_packages $@"
	echo "Attempt $((RETRY_COUNT + 1)) of $MAX_ATTEMPTS: Running install_packages \"$@\""
	echo "Arguments: $@"

[reakaleek]

LGTM. Thank you for making it more stable.

There is an error in CI. But just looks like syntax error or wrong folder?

[gsoldevila]

LGTM. Thank you for making it more stable.

There is an error in CI. But just looks like syntax error or wrong folder?

I forgot to place the script inside the .docker folder, fixed!