You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Air-gapped docs are really useful, but it would be nicer to be able to run docker-compose up -d and docker-compose down.
Also added a README with step-by-step instructions for both vanilla docker and docker-compose.
Gave the instructions in your README a try but found it didn't work for me. I just get the error ~/.git-references/built-docs.git must exist and contain a reference clone of the built-docs repo
when I try and run the build.sh script. This is caused by the if statement within the script. Is this really needed seeing as the next line clones the repository that it complains is missing? Unless I missing something obvious here
@jonny-mcc the current air_gapped/build.sh script (which is being leveraged for local builds in this PR) is designed to run in CI, and given the size of the built-docs repo we want to cache as much as we can on the build image rather than cloning the entire repo on every job. If that fails for any reason we'd rather it fail (to let us know) rather than spending lots of time repeatedly cloning the repo. Not saying it's a good reason, but it is the reason. 😁
You can probably set up a local reference repo of built-docs if you want to use this to build the air-gapped docs locally.
That said, you shouldn't need to build the container if you can instead just download and run the "air-gapped" container image from our (private, internal) Docker registry.
Let me know if that helps, or if you have any other questions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Air-gapped docs are really useful, but it would be nicer to be able to run
docker-compose up -danddocker-compose down.Also added a README with step-by-step instructions for both vanilla docker and docker-compose.