Skip to content

Comments

ci: add macOS entitlements for code signing and notarization#3

Merged
shiyasmohd merged 1 commit intomainfrom
shiyasmohd/add-macos-entitlements
Feb 19, 2026
Merged

ci: add macOS entitlements for code signing and notarization#3
shiyasmohd merged 1 commit intomainfrom
shiyasmohd/add-macos-entitlements

Conversation

@shiyasmohd
Copy link
Contributor

@shiyasmohd shiyasmohd commented Feb 16, 2026

Summary

  • Add entitlements.plist required by the build workflow's macOS code signing and notarization step

Context

The build workflow (.github/workflows/build.yml) references entitlements.plist during the notarize job, but the file was missing from the repo. Without it, macOS code signing fails and no release can be published.

Closes edgeandnode/amp#1759

@shiyasmohd shiyasmohd marked this pull request as draft February 16, 2026 11:37
@shiyasmohd shiyasmohd marked this pull request as ready for review February 19, 2026 08:15
@shiyasmohd shiyasmohd self-assigned this Feb 19, 2026
@shiyasmohd shiyasmohd requested a review from LNSD February 19, 2026 08:15
Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@shiyasmohd shiyasmohd merged commit f7c4427 into main Feb 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add release workflow to ampup repo: build binaries for Linux & macOS with notarization

2 participants