refactor(admin-api): generalize scheduler trait over job kinds#1842
Draft
refactor(admin-api): generalize scheduler trait over job kinds#1842
Conversation
Separate job descriptor construction from scheduling so the scheduler becomes a generic job registration service, pushing dataset-kind awareness to the API handler where request context lives.
- Rename `schedule_dataset_sync_job` to `schedule_job` accepting `JobDescriptorRawOwned`
- Move raw vs. derived job descriptor construction into the deploy handler
- Remove `SerializeJobDescriptor` error variant from scheduler
- Shift `amp-worker-datasets-{raw,derived}` deps from controller to admin-api
Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
LNSD
force-pushed
the
lnsd/refactor-admin-api-job-kinds
branch
from
dda3c5d to
ebfb03e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate job descriptor construction from scheduling so the scheduler becomes a generic job registration service, pushing dataset-kind awareness to the API handler where request context lives.
schedule_dataset_sync_jobtoschedule_jobacceptingJobDescriptorRawOwnedSerializeJobDescriptorerror variant from scheduleramp-worker-datasets-{raw,derived}deps from controller to admin-api